search

bixlabs / documentation

5 stars 1 forks source link

Eslint rules configuration correction #3

Closed ghost closed 7 years ago

ghost commented 7 years ago

Story / Task

Closes https://github.com/bixlabs/documentation/issues/2

Migrations

NO

What this PR does?

Corrects the rules configuration of the .eslintrc file.

Before

Rules of eslint being ignored.

After

Rules of eslint configured correctly.

Related PRs

N/A

How to test / reproduce

TODOs

N/A

@jac1013

acabreragnz commented 7 years ago

.eslintrc without an extension is deprecated, we should rename it to .eslintrc.json,

What do you think @jac1013 @evasquez26?

jac1013 commented 7 years ago

I agree @acabrera91

ghost commented 7 years ago

@acabrera91 sounds good to me

ghost commented 7 years ago

Done guys @acabrera91 @jac1013 :)

jac1013 commented 7 years ago

Seems like we are good to merge this one, @acabrera91 do you agree?

acabreragnz commented 7 years ago

cool, ready to merge :)