search

biz-dev-ops / web-components

Apache License 2.0
0 stars 0 forks source link

Code review #124

Open arjangeertsema opened 1 month ago

arjangeertsema commented 1 month ago

Ik heb een paar vragen over de code:

  1. https://github.com/biz-dev-ops/web-components/blob/eb9f1b355483674f9307f2247c0b02180648dd34/src/bpmn-viewer/index.ts#L31 Waarom geen boolean?
  2. https://github.com/biz-dev-ops/web-components/blob/eb9f1b355483674f9307f2247c0b02180648dd34/src/bpmn-viewer/index.ts#L33 why first updated? What happens when you change the xml?
  3. https://github.com/biz-dev-ops/web-components/blob/eb9f1b355483674f9307f2247c0b02180648dd34/src/bpmn-viewer/index.ts#L102 make this more efficient, first check links or gfx and the get links or gfx (depending which process is most heavy)
jessevanmuijden commented 1 month ago

@arjangeertsema 1, 2 and 3 are fixed in https://github.com/biz-dev-ops/web-components/pull/127. Boolean is used now and firstUpdated as well as updated are needed. 3: code has been made more efficient.