search

bizon / selling-partner-api-sdk

A modularized SDK library for Amazon Selling Partner API (fully typed in TypeScript)
https://bizon.github.io/selling-partner-api-sdk/
MIT License
36 stars 7 forks source link

[feature request] regenerate notifications schemas #964

Open michael-land opened 1 year ago

michael-land commented 1 year ago

B2bAnyOfferChangedNotification schema is missing

B2bAnyOfferChangedNotification.json

tusbar commented 1 year ago

Hi @michael-land

As it is often the case, the source file is broken, so the type does not generate.

https://github.com/amzn/selling-partner-api-models/blob/806b438ed95dde14ad832119cabce81a2570a3da/schemas/notifications/B2bAnyOfferChangedNotification.json#L148

This should be #/definitions/moneyType.

I’ve opened a PR – https://github.com/amzn/selling-partner-api-models/pull/332, but it’s unlikely that it’ll get any attention.

michael-land commented 1 year ago

are you ok with patches to correct those errors while waiting for the schema to be updated?

tusbar commented 3 days ago

This doesn’t fix the issue as the source schema is still broken… but I’m now generating and exposing all the JSON schemas from the source repo to @sp-api-sdk/schemas.

https://github.com/bizon/selling-partner-api-sdk/pull/1316