bizz84
commented
7 years ago @YueJun1991 As SwiftyStoreKit is effectively a singleton and it holds a reference to InAppCompleteTransactionsObserver as soon as you call completeTransactions(), deinit is never called.
Note that completeTransactions() is only called in AppDelegate in the demo app. This is because the payment queue should be registered as soon as the app starts.
It would be incorrect to call completeTransactions() from a view controller or any object that can be deallocated before the callback is received. I'm not sure what your use case is but if you need to do this, make sure you use weak self to prevent retain cycles:
SwiftyStoreKit.completeTransactions() { [weak self] result in
}The same applies for all the other methods in SwiftyStoreKit as they are all asynchronous.
I hope this clarifies things.
Arcovv
Platform
In app purchase type
Environment
Version
0.2.10
Report
Issue summary
Very grateful to this framework, is indeed very easy to use. I originally used this framework for IAP, but later the company's business has re-written a, for comparison, I found that in dealing with 'SKPaymentQueue.remove' there are some differences. Here I have some design problems would like to ask about.
The instance which type of 'InAppCompleteTransactionsObserver' seems like will call SKPaymentQueue.remove method when it will be deinit. But it's the variable optional property of 'SwiftyStoreKit'. When set more 'SwiftyStoreKit.completeTransactions', 'InAppCompleteTransactionsObserver' instance will be nil and removed from SKPaymentQueue?
Recently in the framework of my own design, a few user's app will crash on launch everytime even if the user reinstalls the App and reboots. After some information on the query and you design the framework of the match, I found a single case in the design and 'SKPaymentQueue.remove' very different. I used a singleton to handle all of the 'SKPaymentTransactionObserver' events, but since the singleton rarely triggers 'deinit', I have never used 'SKPaymentQueue.remove', and the result is a crash. I ask is not for this reason I now have been the collapse of the situation? If so, when should I take the initiative to remove? Hope to get some advice.
Here I find some relevant information:
Http://aplus.rs/2012/a-single-bug-in-my-storekit-code-that-lost-me-90-of-iap-sales/ Http://stackoverflow.com/questions/24101185/strange-crash-reports-on-in-app-purchase-code Http://stackoverflow.com/questions/19203921/in-app-purchase-iap-process-appears-to-be-crashing-the-app-on-launch-for-one-o Http://stackoverflow.com/questions/19817130/following-in-app-purchase-app-crashing-on-startup-productidentifier-nil Http://stackoverflow.com/questions/34289204/in-app-purchase-causes-occasional-crash Http://stackoverflow.com/questions/4988663/skpaymentqueue-addtransactionobserver-asking-for-app-store-password-on-startup-a
Thank you very much for your help.