bizz84 / starter_architecture_flutter_firebase

Time Tracking app with Flutter & Firebase
https://codewithandrea.com/
MIT License
1.67k stars 458 forks source link

After tapping 'Retry' button, loading screen does not reappear #147

Open rhinck opened 9 months ago

rhinck commented 9 months ago

https://github.com/bizz84/starter_architecture_flutter_firebase/blob/6ad66f363e3fe956d1371cdcf9fe7df569066609/lib/src/app_startup.dart#L39

With the current code, when I tap the Retry button, no UI change occurs when the provider is invalidated (the UI stays on the error screen and does not show the loading widget).

Is this the intended behavior?


I made a modifications to make the loading state always appear when refreshing from an error, are there any potential downsides you see to this modification?

@Riverpod(keepAlive: true)
Future<void> appStartup(AppStartupRef ref) async {
  ref.onDispose(() {
    // ensure dependent providers are disposed as well
  });

  // (NEW) Set the initial state to loading
  ref.state = const AsyncValue.loading();

  await Future.wait([
    Future.delayed(const Duration(seconds: 5), () {
      throw Exception('Error after 5 seconds');
    }),
    // list of providers to be warmed up
  ]);
}
frankdavid-addae commented 8 months ago

I am also having the same issue. Nothing happens when the Retry button is tapped when an error occurs. How can we rectify this issue?