no such element exception in map diff

bizzabo / diff

Visually compare Scala data structures with out of the box support for arbitrary case classes.

Other

177 stars 17 forks source link

no such element exception in map diff #24

Open drdozer opened 7 years ago

drdozer commented 7 years ago

The show() method in the map diff is broken. It always looks in the right map, but it is called once for elements only in the right map and once for elements only in the left map.

A quick fix is: def show( keys: List[K] ) = keys.map( k => DiffShow.show( k ) -> DiffShow.show( left.getOrElse( k, right( k ) ) ) )

mirelon commented 3 years ago

Still not fixed in version 2.0.1. Is there a plan to make a new release?