search

bizzabo / diff

Visually compare Scala data structures with out of the box support for arbitrary case classes.
Other
177 stars 17 forks source link

Fixes #24 crash when keys were removed from a map #25

Open cvogt opened 7 years ago

hderms commented 5 years ago

would be great to get this merged. We had to vendor the library and make the change ourselves because it was preventing us from using it properly.

cvogt commented 5 years ago

@caente if I could get back merge rights, I would do it :)

caente commented 5 years ago

hey sorry the delay, I was on vacation! what do you think about adding a test that replicates the issue?

mirelon commented 3 years ago

I will continue on this in https://github.com/xdotai/diff/pull/29

mirelon commented 3 years ago

I have added some tests. They were failing before the fix (this one: diff(Map("a" -> "b", "c" -> "d"),Map("a" -> "b"))). With the fix they run OK.