Play2.6 Upgrade. Scala 2.12, 2.11 cross build.

bizzabo / play-json-extensions

+22 field case class formatter and more for play-json

http://cvogt.org/play-json-extensions/api/

Other

196 stars 44 forks source link

Play2.6 Upgrade. Scala 2.12, 2.11 cross build. #40

Closed gitsumanth closed 7 years ago

gitsumanth commented 7 years ago

Based off of this PR, https://github.com/xdotai/play-json-extensions/pull/34

All tests passed. Fixed conflicts from the previous PR.

CLAassistant commented 7 years ago

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

:x: apatzer
:x: sumanth-lumity
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

cvogt commented 7 years ago

hi, sorry. @apatzer didn't sign the CLA. could you redo this on top of https://github.com/xdotai/play-json-extensions/pull/41 ? will publish tomorrow, if this is ready.

cvogt commented 7 years ago

we might actually be able to remove the optionNoError tests now, not 100% sure.

gitsumanth commented 7 years ago

not needed anymore, newer PR exists.