search

bizzabo / play-json-extensions

+22 field case class formatter and more for play-json
http://cvogt.org/play-json-extensions/api/
Other
196 stars 44 forks source link

bump to play-json 2.7.1 and add scala 2.13 support #65

Closed jtjeferreira closed 5 years ago

jtjeferreira commented 5 years ago

fixes #64

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

OlegYch commented 5 years ago

@caente can this please be released?

caente commented 5 years ago

good stuff @OlegYch can you bump the version to 0.30?

OlegYch commented 5 years ago

i believe @jtjeferreira can do that

jtjeferreira commented 5 years ago

@caente @OlegYch Done

caente commented 5 years ago

it's merged, but for actually releasing it to sonatype will take a couple of hours

OlegYch commented 5 years ago

@caente looks like something went wrong, since it didn't yet appear here https://repo1.maven.org/maven2/ai/x/play-json-extensions_2.12/0.30.0

OlegYch commented 5 years ago

@caente ping

caente commented 5 years ago

@OlegYch after too long, I did it, I had to do some sonatype juggling (at least it's free), but I had to remove the scala 2.13 target, the scalamacros were failing for some reason, and I don't have lots of time, if it's important to you, can you take a look? just try to compile with +test:compile, it failed for me.

btw, the new version is 0.30.1 (as I said, sonatype did its usual weird stuff), the README is also updated

OlegYch commented 5 years ago

@caente awesome, thanks +test:compile works fine for me, as well as +publishLocal, so perhaps @jtjeferreira can provide some input

jtjeferreira commented 5 years ago

well, circle-ci says +test:compile works https://circleci.com/gh/xdotai/play-json-extensions

caente commented 5 years ago

that is weird, this is what I'm getting locally

[info] Updating play-json-extensions
[info] Resolved play-json-extensions dependencies
[error] coursier.ResolutionException: Encountered 1 error(s) in dependency resolution:
[error]     org.scalamacros:paradise_2.13.0-M5:2.1.0:
[error]         not found:
jtjeferreira commented 5 years ago

Scalamacros paradise was incoporated in the compiler (https://github.com/scala/scala/releases/tag/v2.13.0-M4). However I don't see who is pulling that dependency...

that is weird, this is what I'm getting locally

[info] Updating play-json-extensions
[info] Resolved play-json-extensions dependencies
[error] coursier.ResolutionException: Encountered 1 error(s) in dependency resolution:
[error]     org.scalamacros:paradise_2.13.0-M5:2.1.0:
[error]         not found: