search

bjarneo / Pytify

A CLI application for controlling Spotify
MIT License
741 stars 40 forks source link

How about tests? #33

Closed lk-geimfari closed 5 years ago

lk-geimfari commented 7 years ago

As the expense of having to add tests?

bjarneo commented 7 years ago

Tests are absolutely something that should be added. :+1:

What testing framework do you recommend?

lk-geimfari commented 7 years ago

@bjarneo I think that the standard unittests library is good choice, but and py.test very good. Let me know which one you choose. I can help you write tests.

bjarneo commented 7 years ago

@lk-geimfari Let's use unittests. Mostly because I've never written a test in Python before, and want to get my hands dirty using the built in testing solution.

Help is appreciated :)

I guess some code needs a refactor in order to test them more easily also.

lk-geimfari commented 7 years ago

@bjarneo I will try to write the basic tests today and send you PR.

bjarneo commented 7 years ago

@lk-geimfari awesome!

lk-geimfari commented 7 years ago

I want to write tests but i can't run project on Linux. I have some problems with dbus. Sorry.

bjarneo commented 7 years ago

@lk-geimfari No worries. Thanks for trying!