search

bjarneo / Pytify

A CLI application for controlling Spotify
MIT License
743 stars 40 forks source link

Read requirements.txt file to fillup install_requires in setup.py #69

Closed bharath-123 closed 4 years ago

bharath-123 commented 4 years ago

Currently, install_requires field in setup function in setup.py is hardcoded for the versions of packages required. Inorder to change the version of a package, we need to change the package version in requirements.txt and setup.py which is unecessary work. Read requirements.txt directly for the required packages.

I encountered this when I was trying to reproduce why prompt_toolkit v1 was failing for pytify.

bharath-123 commented 4 years ago

I will submit a new pull request with an appropriate title. This seems a little messy. Sorry for this :(