search

bjarneo / Pytify

A CLI application for controlling Spotify
MIT License
741 stars 40 forks source link

Upgrade Pytify to support prompt_toolkit v2 #70

Closed bharath-123 closed 5 years ago

bharath-123 commented 5 years ago

This pull request adds support for prompt_toolkit v2 which introduced a lot of breaking changes which rendered Pytify useless.

This change is split into 3 commits. Brief summary of each commit: (i) add support in setup.py to requirements.txt for install_requires. (ii) Add support for prompt_toolkit v2 (The change we have all been waiting for!) (iii) Make prompt_toolkit v2 (2.0.9) default for Pytify.

Each commit has a more a detailed description.

bharath-123 commented 5 years ago

It would be great if some more testing could be done!

bjarneo commented 5 years ago

This is awesome. I will test it tomorrow morning.

bharath-123 commented 5 years ago

Thanks! I ll do testing of my own in the meantime!

bjarneo commented 5 years ago

@bharath-123 Tested it locally as well. Works perfectly fine. Do you want me to merge?

bharath-123 commented 5 years ago

I think its fine to merge :) I ll be sticking around if in case anything breaks! I also make the changes required. But I ll do that as a seperate PR?

bharath-123 commented 5 years ago

Thanks for reviewing :)

bharath-123 commented 5 years ago

Ok I don't think I need to add as a seperate PR. I ll just push the changes to my branch!

bharath-123 commented 5 years ago

My first open source work was with the Linux Kernel. Their mailing list approach is completely different from Github :) So I am really not used to github!

bjarneo commented 5 years ago

My first open source work was with the Linux Kernel. Their mailing list approach is completely different from Github :) So I am really not used to github!

Hopefully the github flow is a lot more simplified? (Cool that you contributed to the linux kernel btw)

bharath-123 commented 5 years ago

My first open source work was with the Linux Kernel. Their mailing list approach is completely different from Github :) So I am really not used to github!

Hopefully the github flow is a lot more simplified? (Cool that you contributed to the linux kernel btw)

I will admit that the mailing lists approach is really simple and neater to review. Less GUI is good sometimes :) But Github is wayy better than Gerrit. I think contributing to the kernel helped me a lot. There are really strict rules on code in the kernel. I am now used to writing detailed commit logs which include motivation of the commit, changes of the commit.

bharath-123 commented 5 years ago

Thanks for the merge!