bjarneo / extract-domain

Extract domain name from an URL
https://www.npmjs.com/package/extract-domain
MIT License
31 stars 4 forks source link

Add some more negative tests #17

Closed peternewman closed 2 years ago

peternewman commented 2 years ago

Blocked behind #16

bjarneo commented 2 years ago

Thanks for all the helpful PRs submitted. Really appreciated :)

peternewman commented 2 years ago

No worries, you might want to make the GitHub action passing mandatory...

I was a bit surprised when I went chasing a bug on a website and found the co.uk was due to the library by default. I'll have a play but I suspect this may confuse it... https://www.gov.uk/