search

bjascob / amrlib

A python library that makes AMR parsing, generation and visualization simple.
MIT License
219 stars 34 forks source link

switch inference logging from standard out to logging module #55

Closed plandes closed 1 year ago

plandes commented 2 years ago

Switch inference logging from standard out to logging module.

bjascob commented 1 year ago

Unfortunately, setting the statements to "info" will mean that users will not see any output at the default logging level and may think the system is frozen while loading the module. If the two print statements are a serious issue a "-quiet" option could be added to the code. However, this parser is older and produces much lower scores that the others so I expect the code will not be used much in the future.

plandes commented 1 year ago

@bjascob Any project that uses your library will most likely be using the standard Python logging system as they will be larger projects. It's very easy to set the logging system to log info with one line (two with the import):

import logging
logging.basicConfig(level=logging.INFO)

Regarding the usage of this parser: if others are like me, the parser is used more than the others for prototyping as its the fastest.

For these reasons I'd ask you reconsider your decision to not merge this pull request.

Thank you.