search

bjbvoesenek / qPCR-analysis

GNU General Public License v3.0
1 stars 0 forks source link

Working directory is currently hard-coded. #1

Closed ifokkema closed 1 year ago

ifokkema commented 1 year ago

The working directory is currently hard-coded: https://github.com/bjbvoesenek/qPCR-analysis/blob/2b49bf13fba765547933ca3be6fe03b8499e2478/qpcr_analysis.py#L12-L15

This makes it currently impossible to enable the web wrapper. I see multiple possible solutions:

  1. The file that's to be processed becomes an argument, and the script should be called providing the input file name. The script can then change to the directory of the given filename to create output there.
  2. The current directory from which the script is called is used. In that case, the manual should indicate that one should first move to the directory where Analysis.xlsx is found, before invoking the script. Also, the script should no longer change the cwd.

I'm fine with either, although it would be more user-friendly to go for 1. But again, I have no preference, and if the web wrapper is your primary intended method of use by others, then option 2 is just fine as well.

bjbvoesenek commented 1 year ago

I think the best way is to let the user click on the file they want to upload on the website for analysis, just like with the 'Transpose' script.

Maybe we can have a look tomorrow how it is coded there, since that should definitely work

ifokkema commented 1 year ago

Sure, the user can upload whatever file they want, but these lines require the server to have the path I:/lab-j/Bas/qPCR script. The server does not have that path :wink: But yes, of course we can discuss in more detail tomorrow!

ifokkema commented 1 year ago

Fixed in 1bc0fdef1c01ff132cd71d0a63c702ad747ea122.