bjbvoesenek / qPCR-analysis

GNU General Public License v3.0
1 stars 0 forks source link

Bjbvoesenek nr housekeeping genes and control lines now variable #10

Closed bjbvoesenek closed 1 year ago

ifokkema commented 1 year ago

By the way, I now see that this PR is merging your branch into main, but it should have been set to merge into the release/2.0 branch :wink: The reason for this is that merging into main would cause the web interface to break. This is still set to use python3 qpcr_analysis.py INPUT GENE1 GENE2 but this won't work anymore with this change. So we need to collect all changes outside of main and test everything before we're completely done and merge everything in main. In principle, main should be stable and should always contain a working version.

bjbvoesenek commented 1 year ago

By the way, I now see that this PR is merging your branch into main, but it should have been set to merge into the release/2.0 branch 😉 The reason for this is that merging into main would cause the web interface to break. This is still set to use python3 qpcr_analysis.py INPUT GENE1 GENE2 but this won't work anymore with this change. So we need to collect all changes outside of main and test everything before we're completely done and merge everything in main. In principle, main should be stable and should always contain a working version.

You are right, sorry! Let me create a new PR. I adapted your changes so it should be okay now