Review U2 Making Computers Do Math

bjc-edc / bjc-r

The Beauty and Joy of Computing public resource repository.

http://bjc.edc.org/

12 stars 19 forks source link

Review U2 Making Computers Do Math #24

Open maryfries opened 5 years ago

maryfries commented 5 years ago

"New" FP content based on older cut content

Probably needs a more careful review than Modeling Language, but not super close. I'm leaning toward having the U3 extension of this project be a required lab page (if we can fit it in given the structural changes we end up making), and I still think it's ok for this to be optional.

http://localhost/bjc-r/cur/programming/2-complexity/3-predicates/6-math.html

brianharvey commented 5 years ago

Edited. Can't decide about optional vs required until I see the U3 one, next.

maryfries commented 5 years ago

@brianharvey I don't see any edits from you (here, where it was or here, where it is). But we've edited this page together fairly recently; are you happy with it now?

maryfries commented 5 years ago

My notes (on the U2 topic page) say we agreed to make this page required in U2L3 just before the last page. I suppose all that is left is for @EPaulG to review and weigh in. Paul, this is the page to review, and also see my notes and suggested placement in U2L3 on the U2 topic page. Be sure to sync, of course. :)

maryfries commented 5 years ago

PG said: "Looks fine to me."

brianharvey commented 5 years ago

In the yellow box to the right of FYTD 1, the appearance makes it seem as if it's this paragraph that's obsolete. Instead of a floating picture, put the red Obsolete block inline in the text: "If your EVEN? block looks like (picture) instead, ..."

maryfries commented 5 years ago

[ ] Thanks @brianharvey; see if you like my edit. If you do, you can unassign yourself (or close the issue if Paul's already weighed in). I did mostly what you asked for, and I also made it an endnote because it was getting crowded and feeling less sidenotey.
[ ] @EPaulG, thanks for reviewing! Can you also weigh in on making this required at the end of 2.3 as Brian and I propose? (Once you do, you can either unassign yourself in the upper right under the green New Issue button or close the issue if BH has already responded to my response to him in the previous paragraph of this comment.)

Thank you both!! :)