search

bjcarlson42 / benjamincarlson.io

My personal website built with Next.js, Chakra UI, Firebase, and next-mdx-remeote.
https://benjamincarlson.io
MIT License
141 stars 23 forks source link

Multilingual #33

Open vahidtakro opened 2 years ago

vahidtakro commented 2 years ago

HIi, can I make it multilingual? I mean the markdown blog.

bjcarlson42 commented 2 years ago

Sure. Feel free to create a pr.

bjcarlson42 commented 2 years ago

@vahidtakro Haven't heard from you in a while. Do you still plan on implementing this?

vahidtakro commented 2 years ago

Hello Benjamin, yes of course we can do it, I am just a very basic react learner. but we can try.

bjcarlson42 commented 2 years ago

No worries! I'll try and help any way I can.

vahidtakro commented 2 years ago

perfect! do you prefer to edit this project or make a new branch or my forked project?

bjcarlson42 commented 2 years ago

you can clone this repo and then create a new branch.

vahidtakro commented 2 years ago

Benjamin, I can not npm start the project.

bjcarlson42 commented 2 years ago

I use yarn. So once you clone the repo run "yarn" to install the dependencies and then run "yarn dev" to start the server.

vahidtakro commented 2 years ago

I already multilingualed the values, about the MDX, I am not sure. Can you help multilingualing it?

bjcarlson42 commented 2 years ago

Could you submit a pull request so I can see the code so far?

vahidtakro commented 2 years ago

Could you submit a pull request so I can see the code so far?

I have all files on my localhost, how can I do that? should I create a repo for that? (sorry I am a new Github user)

bjcarlson42 commented 2 years ago

You can simply commit them to GitHub just like any other project. Use the command, git push, or if you are in viscose you can use the ui. Once you do that, if you go to the code of this repo(https://github.com/bjcarlson42/benjamincarlson.io), you should see a button pop up at the top saying something like "create a pull request" Click yes and follow the steps. If you need help you can always check out githubs own learn page: https://lab.github.com

vahidtakro commented 2 years ago

I get this error:

git push origin master remote: Permission to bjcarlson42/benjamincarlson.io.git denied to vahidtakro. fatal: unable to access 'https://github.com/bjcarlson42/benjamincarlson.io.git/': The requested URL returned error: 403

bjcarlson42 commented 2 years ago

You might need to fork it first. Check out this video: https://www.youtube.com/watch?v=8A4TsoXJOs8

vahidtakro commented 2 years ago

You might need to fork it first. Check out this video: https://www.youtube.com/watch?v=8A4TsoXJOs8

thanks, pull request done, I just added multilingual feature, already translated menu. but still need to add language switcher and translate pages and MDX files.