Fix L33tMatch constructor to avoid setting the sub array to null

bjeavons / zxcvbn-php

Realistic PHP password strength estimate library based on Zxcvbn JS

MIT License

831 stars 113 forks source link

Fix L33tMatch constructor to avoid setting the sub array to null #59

Closed lmcnearney closed 2 years ago

lmcnearney commented 2 years ago

This should fix a potential PHP warning:

foreach() argument must be of type array|object, null given in .../vendor/bjeavons/zxcvbn-php/src/Matchers/L33tMatch.php on line 214

mkopinsky commented 2 years ago

Thanks for the well-written issue and PR!

I will look into this in the next few days - looks good at first glance but I want to see if there's a better way to fix it. I'm also curious to see what they do about this in the upstream library. (Could very well be that this level of implementation detail doesn't exist in upstream.)

@bjeavons can you enable the setting for Github Actions to run on PRs from forks? If that doesn't work (or he doesn't see this message) I'll recreate this PR in a branch rather than a fork so tests will run.

bjeavons commented 2 years ago

Hi, I updated it to "Require approval for first-time contributors who are new to GitHub" from "Require approval for first-time contributors". That was the only relevant setting I saw but please let me know if I missed something

mkopinsky commented 2 years ago

@Xon @Zenexer Can you confirm whether #60 included all the relevant changes from this?

Zenexer commented 2 years ago

Checking now.

Zenexer commented 2 years ago

Yes, #60 includes this change.

mkopinsky commented 2 years ago

Thanks!