refactor: set margin on slot instead of specific footer

bjerkio / website

Bjerk's official website, built using Astro 🚀

https://bjerk.io/

7 stars 2 forks source link

Closed Xillians closed 3 months ago

Xillians commented 3 months ago

This makes it so the margin to keep distance between slot and footer is not based on which footer is shown.

a simple refactor where we move what html has margin top / bottom.

This can be done in 1 of 2 ways:

Option 1: we move the contact footer to be in main footer file, and that footer has margin top -> then show the two footers

Option 2: we do this where we wrap the slot in a div and add a margin at its bottom instead

github-actions[bot] commented 3 months ago

Visit the preview URL for this PR (updated for commit 98f7e5b):

_{(expires Sat, 07 Sep 2024 13:02:52 GMT)}

_{Sign: f444ce0cdc4b1d54f70522cf8972a3a2e20b19ad}