search

bji / libs3

Other
154 stars 151 forks source link

Fix uploading large amounts of data #85

Closed meinemitternacht closed 5 years ago

meinemitternacht commented 6 years ago

When uploading large amounts of data (> 5 GB), libs3 refuses the upload with an error. This pull request increases the single-object limit to 5 TB, which brings it in line with S3's object limit.

After increasing that limit, a new bug was discovered in growbuffer_append(). The XML produced by put_object() was being truncated if more than one growbuffer was allocated.

If there are any questions about this pull request, please let me know.

bji commented 5 years ago

Rejecting due to no response to my question.

meinemitternacht commented 5 years ago

@bji There is no question to respond to, unless it is visible only to your account.

bji commented 5 years ago

OK sorry, not sure why the question I asked is not visible. I will try to make it so.

bji commented 5 years ago

I clicked the 'begin review' button which I guess I neglected to click before. Can you see my question now?

meinemitternacht commented 5 years ago

Yes, thank you. I have replied to your question above.

bjitivo commented 5 years ago

Yes, multipart upload was added by another contributor some time after that function was made and the comment is out of date. Thanks for your change.

bjitivo commented 5 years ago

Oops wrong account.