search

bjin / mpv-prescalers

prescalers for mpv, as user shaders
GNU Lesser General Public License v3.0
355 stars 34 forks source link

Remove vulkan variants #58

Closed haasn closed 1 year ago

haasn commented 1 year ago

libplacebo has supported rgba16f on vulkan since 2019, and on d3d11 since jan 2023. 'rgba16hf' shader variants are unnecessary

bjin commented 1 year ago

Thanks! I didn't notice these changes.

haasn commented 1 year ago

Incidentally, we can probably also remove need for compute variants by making CS support testable in conditions..

bjin commented 1 year ago

With my implementation compute/ shaders are usually slower than gather/ shaders for luma prescalers, but faster for -rgb prescalers. So probably not a good idea to prefer it blindly.

I was actually thinking about removing gather/ shaders by testing HOOKED_gather macro defined by libplacebo, but it will introduce more a lot of complexity to shader code and I eventually give up this idea.