bjlittle / geovista

Cartographic rendering and mesh analytics powered by PyVista
https://geovista.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
159 stars 26 forks source link

offset or drawn order for add_coastlines #203

Closed PBrockmann closed 1 year ago

PBrockmann commented 1 year ago

I cannot see coastlines from the example code:

import geovista as gv
from geovista.pantry import lfric_sst
import geovista.theme

# Load the sample data.
sample = lfric_sst()

# Create the mesh from the sample data.
mesh = gv.Transform.from_unstructured(
    sample.lons,
    sample.lats,
    connectivity=sample.connectivity,
    data=sample.data,
)

# Plot the mesh on a Robinson projection using an ESRI spatial reference identifier.
plotter = gv.GeoPlotter(crs="ESRI:54030")
sargs = {"title": f"{sample.name} / {sample.units}"}
plotter.add_mesh(mesh, cmap="thermal", show_edges=True, scalar_bar_args=sargs)
plotter.add_coastlines(resolution="50m", color="white")
plotter.view_xy()
plotter.add_axes()
plotter.show()
bjlittle commented 1 year ago

@PBrockmann Yup, I've yet to add support for projecting and ripping lines.

That's going to be forthcoming soon.

To keep things honest, I'm going to leave this issue open and close it once that capability is available in geovista... and if your up for it, you can test it at your end when it lands, to confirm that it's working as expected.

At the same time I'll also have support for gridlines (or a graticule) so that you can decorate the render on the sphere or a projection to help geolocate the plot.

Does that seem reasonable at the moment with you?

bjlittle commented 1 year ago

Also, thanks again for kicking the tyres of geovista and taking the time to feedback.

It's totally priceless and much appreciated! 🍻

PBrockmann commented 1 year ago

Sure. I am discovering geovista while I am investigating pyvista. See: https://github.com/pyvista/pyvista/discussions/2567

Interested in the approach and the features you intend to cover. Will be glad to help, contribute if I can.

bjlittle commented 1 year ago

You may be also interested in https://github.com/pyvista/pyvista-xarray.

It's being developed by @banesullivan who is one of the founding creators of pyvista and a vtk guru from kitware.

We're trying to join some dots in capability...

The intention is that pyvista-xarray will leverage geovista under the hood.

bjlittle commented 1 year ago

@PBrockmann Don't know if you've noticed yet, but I've already used some data that you shared with me a while back, which I'm using as example data in the geovista pantry which you can see with:

geovista examples --run from_unstructured__hexahedron --verbose

and

geovista examles --run from_unstructured__hexahedron_poly --verbose

I'd love to be able to cite you properly, see geovista-data README.md. Are my citation details for you correct?

Also, if you'd prefer I used more exciting data instead, then please let me know, as I'm only using pretty dull synthetically generated data I created myself 👍

And if you want me to correct any detail regarding referencing you data or model then I'd love to do that in the examples scripts:

PBrockmann commented 1 year ago

No problem.

Please mention: Data from the DYNAMICO project, a new dynamical core for LMDZ, the atmospheric general circulation model (GCM) part of IPSL-CM Earth System Model (IPSL - INSTITUT PIERRE-SIMON LAPLACE - France).

bjlittle commented 1 year ago

Thanks!

Did you have any data that you'd prefer that I used? I'm happy to replace the sample that I've got if it better showcases your model?

PBrockmann commented 1 year ago

For now it will be ok. Thanks