search

bjlittle / geovista

Cartographic rendering and mesh analytics powered by PyVista
https://geovista.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
164 stars 27 forks source link

Refactoring of move vtk to PyVista #452

Open tkoyama010 opened 1 year ago

tkoyama010 commented 1 year ago

📰 Custom Issue

I found a place in the existing code where it can be done in PyVista but is expressed in vtk. @bjlittle Are you fine changing it to PyVista representation?

# We need to add `check_mesh` option in PyVista
remeshed: pv.PolyData = poly1.intersection(
    poly2, check_mesh=check, split_first=True, split_second=False
)

https://github.com/bjlittle/geovista/blob/933fe2679aa6059d6c1f79ba4f187345460e8217/src/geovista/filters.py#L125-L137

bjlittle commented 1 year ago

@tkoyama010 THB I'm not sure.

I'll need to check that this is giving me the behaviour that we require, but I don't think that it does.

I'll investigate and share the results with you asap 👍

yutik-nn commented 9 months ago

So I've just created a new working environment in a new workspace, and pv.set_jupyter_backend("trame")totally does not work. No matter if I reinstall or update ipywidgets, trame, and vtk I get the following error:

image

What do I do?

bjlittle commented 8 months ago

So I've just created a new working environment in a new workspace, and pv.set_jupyter_backend("trame")totally does not work. No matter if I reinstall or update ipywidgets, ...

What do I do?

Created issue https://github.com/bjlittle/geovista/issues/743 to investigate this 👍