search

bjlittle / geovista

Cartographic rendering and mesh analytics powered by PyVista
https://geovista.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
159 stars 26 forks source link

fix the error of GH104 #685

Closed tkoyama010 closed 8 months ago

tkoyama010 commented 8 months ago

🚀 Pull Request

Description

See https://learn.scientific-python.org/development/guides/gha-wheels#GH104. See #684.

tkoyama010 commented 8 months ago

@bjlittle OK. I fixed the new GH104 rules. It is a good rule in my mind.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2485e8b) 94.65% compared to head (1818d0f) 94.65%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #685 +/- ## ======================================= Coverage 94.65% 94.65% ======================================= Files 129 129 Lines 4900 4900 ======================================= Hits 4638 4638 Misses 262 262 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bjlittle commented 8 months ago

@tkoyama010 Awesome, thanks for being all over this! :beers: :rocket: