search

bjlittle / geovista

Cartographic rendering and mesh analytics powered by PyVista
https://geovista.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
158 stars 24 forks source link

docs: use os.walk not pathlib.Path.walk #870

Closed bjlittle closed 3 months ago

bjlittle commented 3 months ago

🚀 Pull Request

Description

This pull request reverts to using os.walk instead of pathlib.Path.walk, which was only introduced in Python 3.12.

Discovered this issue whilst serendipitously building the docs gallery carousel using python==3.11.

The GHA CI is configured to only build the docs with the latest supported version of python, which is 3.12. Hence why this was overlooked :neutral_face:

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.30%. Comparing base (c16ccf8) to head (f6f9d06). Report is 228 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #870 +/- ## ======================================= Coverage 91.30% 91.30% ======================================= Files 58 58 Lines 2934 2934 ======================================= Hits 2679 2679 Misses 255 255 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.