search

bjlittle / geovista

Cartographic rendering and mesh analytics powered by PyVista
https://geovista.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
143 stars 22 forks source link

default spatial args for geoplotter view_poi #982

Closed bjlittle closed 3 weeks ago

bjlittle commented 3 weeks ago

🚀 Pull Request

Description

This pull-request extends the goevista.geoplotter.GeoPlotterBase.view_poi method to allow only 1 spatial argument instead of accepting either none or enforcing both are provided.

The missing spatial argument defaults to 0 e.g., plotter.view_poi(x=30) instead of plotter.view_poi(x=30, y=0)

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.30%. Comparing base (a9ba098) to head (c71d10b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #982 +/- ## ======================================= Coverage 91.30% 91.30% ======================================= Files 58 58 Lines 2934 2934 ======================================= Hits 2679 2679 Misses 255 255 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.