search

bjmorgan / kinisi

A Python package for estimating diffusion properties from molecular dynamics simulations.
https://kinisi.readthedocs.io
MIT License
49 stars 11 forks source link

suggestion for CONTRIBUTING.md #40

Closed lamdalamda closed 8 months ago

lamdalamda commented 8 months ago

Here:

3. Install your local copy into a virtualenv. Assuming you have virtualenvwrapper installed, this is how you set up your fork for local development::

    $ mkvirtualenv kinisi
    $ cd kinisi/
    $ python setup.py develop

I couldn't find the setup.py (is it because I use conda instead of mkvirtualenv?), I guess it shall be installed in this way

pip install .[dev]
bjmorgan commented 8 months ago

@arm61 it looks like these instructions are outdated since you changed the build system to use pyproject.toml?

arm61 commented 8 months ago

Yeah I have just fixed it. @lamdalamda can you check that the contributing guidelines make sense now?

lamdalamda commented 8 months ago

Looks great! Thank you for your instant reply @arm61 @bjmorgan