bjmorgan / pyscses

PYthon Space-Charge Site-Explicit Solver
MIT License
8 stars 4 forks source link

Defect Boltzmann factor refactoring #16

Closed bjmorgan closed 3 years ago

bjmorgan commented 3 years ago

The Boltzmann factors and associated terms for calculating site occupancies are currently split across boltzmann_one(), boltzmann_two(), and boltzmann_three() in the DefectAtSite class. This makes the code overly complex and hard to read.

Proposal to refactor this code to a single boltzmann_factor() method and write the more complex functions explicitly where they are needed.