v1.0.0 release?

[kbond]

What do you think? Ready for v1.0.0 release?

[bjo3rnf]

Why not? Do you use the bundle in production and what about the failing build on travis for PHP5.4?

[kbond]

Yes, I use this in a couple production apps. That fail was an issue with gihub/packagist.

See the latest here: https://travis-ci.org/dreipunktnull/DpnXmlSitemapBundle

[bjo3rnf]

Ok then...what now? :)

[kbond]

do you mean how do you create a v1.0.0 release?

[bjo3rnf]

Uhm...yes :\

[kbond]

are you using git cli or some sort of gui?

[bjo3rnf]

cli

[kbond]

# on latest master
git tag v1.0.0
git push --tags

This will create a new release on packagist

[kbond]

excellent: https://packagist.org/packages/dpn/xml-sitemap-bundle

[bjo3rnf]

Ok, thanks for helping a noob :+1: . Reading over composer.json I am not sure if the dependencies are a little too "greedy".

[kbond]

yeah mean with using the *'s?

[bjo3rnf]

Those and I don't think full symfony/framework-bundle is required. I'll have a look later.

[kbond]

I haven't tested in a symfony 2.0 project but I think it does work

I usually require the symfony/framework-bundle when creating a bundle, but that's just me. The only actual dependency I see is here: https://github.com/dreipunktnull/DpnXmlSitemapBundle/blob/master/Controller/Controller.php#L17 but this can be changed to use Symfony/Component/Routing/Router (i think)

[bjo3rnf]

There are some more like RedirectResponse, Configuration and soon Command. I'll go through the code and see what can be done.

[kbond]

Certainly, once you add the Command, it will need to require the framework-bundle

FYI - RedirectResponse is from symfony/http-foundation and Configuration is from symfony/config