search

bjodah / pyneqsys

Solve symbolically defined systems of non-linear equations numerically.
BSD 2-Clause "Simplified" License
47 stars 4 forks source link

Adding DOIs to the references #33

Closed andim closed 6 years ago

andim commented 6 years ago

[This issue is part of the JOSS review, see openjournals/joss-reviews/issues/531.]

Could you please add DOIs to the references where not already done? At least for the sundials paper their appears to be one (10.1145/1089014.1089020) potentially also for some of the other references.

bjodah commented 6 years ago

Thanks for the SUNDIALS doi (I missed it the first time). For the other references I came up empty handed. However the NLEQ2 now has a "urn" identifier which ZIB asked that citing parties use.

andim commented 6 years ago

Sounds good. I don't want to send you hunting DOIs that don't exist, but you could add the one for Sundials. :+1:

bjodah commented 6 years ago

Thanks, I added it: https://github.com/bjodah/pyneqsys/blob/master/joss-paper/paper.bib#L15