Include path not done right for cocoa touch example

[GoogleCodeExporter]

I believe that the way the Core-plot static library is set up for the cocoa 
touch example is not 
right or at least not the recommended way. This leads to the need for an odd 
configuration in 
the CPTestApp-iPhone project. 

To be correct, the header search path in the example project should point to 
where the static lib 
is build, not to any directory used by the library project. 

For example, the right path for the header search paths on the example should 
be in the form:

../../framework/build/${BUILD_STYLE}-${PLATFORM_NAME}/usr/local/include

instead of the current:

../../framework/iPhoneOnly
../../framework/Source
../../framework

This is the right way to do it because in the core-plot library target we 
already specify the right 
Copy Headers, as it should be.

Since the header files will be copied to the build directory when the library 
is built, and the 
example will access to the directory where they are copied, there is no need to 
prefix all 
referenced headers in CorePlot-CocoaTouch.h with "Source/" or "iPhoneOnly/". 
The build 
process just copies all headers under the same built directory, so no further 
reference to Source/ 
or iPhoneOnly is needed. Actually it would not work unless such prefixes are 
removed.

Just my 2 cents,

Joan Lluch-Zorrilla

Original issue reported on code.google.com by carbon...@gmail.com on 11 May 2010 at 6:46

[GoogleCodeExporter]

Original comment by drewmcco...@mac.com on 12 May 2010 at 8:36

• Changed state: Accepted

[GoogleCodeExporter]

This was accepted but as fas as I understand it is not yet submitted.

Also, I believe the CPTestApp-iPhone still links always to the Debug build of 
core-plot  regardless of the actual configuration on the user project, because 
there is a fixed path in the 'Library Search Path' settings for all 
configurations on the example.

Once the static lib is included in the user project, the 'Library reach Path' 
should be left blank. I think I have done it right in the Performance branch, 
but this is not yet submitted to the default branch.

Thanks.

John

Original comment by carbon...@gmail.com on 23 Jun 2010 at 8:52

[GoogleCodeExporter]

Hi John,
Seems like you know how to fix this best. Why not just go to the default 
branch, and commit the fix.

hg branch default
<Fix issue>
hg ci 
hg push

Drew

Original comment by drewmcco...@mac.com on 23 Jun 2010 at 9:25

[GoogleCodeExporter]

Fixed by revision a01603751e.

Original comment by eskr...@mac.com on 25 Jun 2010 at 2:22

• Changed state: Fixed