Closed stephanenicolas closed 5 years ago
@drewhannay thx for the comment ! I just pushed a commit to fix it, the change is a few lines above your comment.
LGTM! FYI one of us will have to update our PR, depending on who gets merged first :)
Thx for the review @drewhannay . @bjoernQ we're quite ready :)
@stephanenicolas just merged the other PR - this one needs an update now unfortunately
@drewhannay @bjoernQ here is the new PR. I changed quite a few things from my previous PR and actually re-ordered a few things in the plugin to take into account the lazy configurations and the tests variants.
Now things are more clear:
LGTM :)
Solves issue #51
I made all changes. Now tasks are created per variant (e.g. unMockDebugUnitTest, unmockMyBuildTypeReleaseUnitTest, etc.).
There is no afterEvaluate block anymore.
And cherry on top of the cake, as the plugin is in Groovy, it benefits from a full dynamic typing and doesn't rely on the android plugin ;) . But honnestly it would be better to have it typed, in kotlin, and depending on the plugin IMHO.