search

bjork24 / Unison

Unifying named breakpoints across CSS, JS, and HTML
http://bjork24.github.io/Unison
MIT License
453 stars 41 forks source link

AMD compatibility & manual initialization #15

Open peschee opened 10 years ago

peschee commented 10 years ago

Hi

I have added some changes in my custom branch to support AMD loaders and to be able to initialize Unison "manually". The problem with the original implementation was, that if included it inside your own DOMContentLoaded listener, the event inside Unison never fires (since it fires once). I added the public util.initializeUnison method which can be called manually and initializes Unison.

Also, I added an .editorconfig file to support your syntax and made some format changes. Feel free to include this in your version.

P.S. Unison should still be exposed to the global namespace, so I assume that your comments plugin still works. However, I wasn't able to test this. Also, I have not added a minified version since I wasn't sure which minifier you usually use for your releases.

peschee commented 10 years ago

Any update on this? Can you please take a look @bjork24?

weotch commented 9 years ago

Btw, this pull request made the difference for me. I ended up doing to fire stuff on load:

Unison.util.initializeUnison();
// ... add event listeners
Unison.emit(Unison.fetch.now().name);
peschee commented 9 years ago

It seems as if @bjork24 is not really maintaining this anymore. But I guess we can live with forks.