search

bjorn / rpgdx

RPGDX
http://rpgdx.net
2 stars 3 forks source link

Duplicate defines #12

Closed Poikilos closed 3 months ago

Poikilos commented 3 months ago
  • I had to comment out a lot more duplicate defines. Actually I don't know what the code expected before, but I've basically commented out all RPGDX-specific defines from forums/includes/constants.php (except READS_TABLE), since they were also being defined at includes/constants.php. It's a local change until we figure out the proper fix.

-@bjorn https://github.com/bjorn/rpgdx/pull/9#issuecomment-2125645067

Poikilos commented 3 months ago

We can merge the two files then fix the includes to always use the one in forums, since that is probably the proper place for it.

Poikilos commented 3 months ago

They would have to be compared carefully to see what code assumed which values, if they two files differ in effect in one or more of the constants.