bjorn / rpgdx

RPGDX
http://rpgdx.net
2 stars 3 forks source link

Add PHP 8.x compatibilty (tested on PHP 8.2). Document the installation of shims to run old PHP functions. #9

Closed Poikilos closed 3 months ago

bjorn commented 3 months ago

This is really an amazing feat! There's so much involved in this update, it's a little baffling how you've actually pulled it off. Thank you!

Now, there are still some remaining issues:

And then there are some errors I haven't gotten around to look into yet:

But again, thank you so much for all the updates! It would be great if you can help resolve the remaining issues as well, but I'll also see if I can resolve some of these eventually.

bjorn commented 3 months ago

I've addressed the sizeof() error in 661857c21cf4e4bdaea72141bac71d1c84bc7be5 and created #10 about the empty forum posts.

Poikilos commented 3 months ago
  • I've changed the server to use a git checkout, to make it easier to keep it up to date. However, now the deletion of forums/install is a local change. Do you have any suggestions for dealing with this?

See https://github.com/bjorn/rpgdx/issues/11#issuecomment-2125937029

Poikilos commented 3 months ago
  • It would be nice if the database user wasn't edited into a checked-in file. Maybe forums/config.php should be moved to forums/config.php.sample?

Yes!

Then add config.php to .gitignore

Poikilos commented 3 months ago

You are very welcome. I have fond memories of playing the RPGs on the site.