search

bjorn2404 / jQuery-Store-Locator-Plugin

A store locator plugin using Google Maps API version 3
MIT License
495 stars 235 forks source link

Precompiled Handlebars templating causing performance issues on crappy CMS? #102

Closed takes12no1 closed 8 years ago

takes12no1 commented 8 years ago

I am new to using Github, please forgive if this is the wrong forum for such a request. This project has been very helpful for me to get a branch locator up quickly. However, I am using this on a CMS that is horrible and does script and code injections for every page served. So When results are templated the performance speed takes a huge hit. I will need to dig in and make a version without templating. Any Resources that anyone could point me to would be much appreciated.

bjorn2404 commented 8 years ago

I'm assuming you're talking about the Handlebars templates. You might try doing inline templates with the listTemplateID and infowindowTemplateID plugin settings to avoid having the templates in separate files. The second example on the Handlebars site is what a template looks like within a script tag.

takes12no1 commented 8 years ago

Interesting, so you're saying by compiling the template in the browser (using he script method) instead of pre-compiling it, I might overcome the issue. Thanks, I will pursue that route. If I discover this helps, is it cool to post the solution here to potentially help someone else? I know the use case is rare but still...

bjorn2404 commented 8 years ago

Well, you could just try doing the templates with inline JS. If that's still not good enough you could go the compiled route - there's a Grunt package out there for doing that.