search

bjorn2404 / jQuery-Store-Locator-Plugin

A store locator plugin using Google Maps API version 3
MIT License
495 stars 235 forks source link

Win 10 / IE 11 breaks with JSON or XML after 544 records #189

Closed jmp100 closed 7 years ago

jmp100 commented 7 years ago

Doesn't work with json data, by address or zipcode. No issues with any other browser.

jmp100 commented 7 years ago

I believe it's the data. 700 records probably a character breaking the process for IE.

jmp100 commented 7 years ago

I validated the json @ JSONLint. No issues with data. IE breaks at about record 544. With either real time php json data or static json file.

Any help on this appreciated. James

jmp100 commented 7 years ago

I changed the data type to xml. Scripted out the location data. Same issue with IE 11 and earlier browser versions. Breaks after 544 records.

jmp100 commented 7 years ago

No problems with data. I scripted out using the xml schema replacing the name, lon and lat fields with real data. Same issue IE, breaks after 544 records. Sample below without brackets.

markers marker name="3C" lat="39.4900220000" lng="-83.6502520000" category="Restaurant" address="3040 Excelsior Blvd" address2="" city="Minneapolis" state="MN" postal="55416" country="US" phone="612-922-6662" email="info@chipotle.com" web="" hours1="Mon-Sun 11am-10pm" hours2="" hours3="" featured="" features=""/ marker name="A4T" lat="45.1392640000" lng="-95.0523150000" category="Restaurant" address="3040 Excelsior Blvd" address2="" city="Minneapolis" state="MN" postal="55416" country="US" phone="612-922-6662" email="info@chipotle.com" web="" hours1="Mon-Sun 11am-10pm" hours2="" hours3="" featured="" features=""/ marker name="AA4X4" lat="45.4370370000" lng="-117.2888080000" category="Restaurant" address="3040 Excelsior Blvd" address2="" city="Minneapolis" state="MN" postal="55416" country="US" phone="612-922-6662" email="info@chipotle.com" web="" hours1="Mon-Sun 11am-10pm" hours2="" hours3="" featured="" features=""/ marker name="AADTCA" lat="42.7007840000" lng="-84.5490050000" category="Restaurant" address="3040 Excelsior Blvd" address2="" city="Minneapolis" state="MN" postal="55416" country="US" phone="612-922-6662" email="info@chipotle.com" web="" hours1="Mon-Sun 11am-10pm" hours2="" hours3="" featured="" features=""/

/markers

jmp100 commented 7 years ago

@bjorn2404 @GiancarloGomez @JimmyRittenborg @collinanderson @quayzar

Is this project dead without issue support? In need of a fix asap. I can provide xml test data.

Thanks, James

GiancarloGomez commented 7 years ago

Hey @jmp100 what issues are you experiencing? Have you turned on debugging?

jmp100 commented 7 years ago

No issues reported with IE debugger & console. I can attach xml sample data of nearly 700 records for testing using the stock xml template.

GiancarloGomez commented 7 years ago

Hey @jmp100, I have contributed before to this project but I do not manage it. If you'd like I can offer some paid support.

GiancarloGomez commented 7 years ago

Before that though, I was referring to turning on debug mode on the plugin and seeing what is happening when the data comes in.

jmp100 commented 7 years ago

Oh.. ok will try that..

jmp100 commented 7 years ago

No debug info posting..

GiancarloGomez commented 7 years ago

You should see some stuff by enabling it. You see nothing at all? Can you paste the snippet code here of how you are instantiating the plugin.

jmp100 commented 7 years ago

The php file outputs xml, no issues with that.

$(function() { $('#bh-sl-map-container').storeLocator({ 'dataType': 'xml', 'dataLocation': 'data/locations2.php', 'inlineDirections': true, 'mapSettings': { zoom : 9, mapTypeId: google.maps.MapTypeId.ROADMAP },
'storeLimit': '26', 'debug': 'true' }); });

GiancarloGomez commented 7 years ago

and you see nothing coming back at all? Not even the XHR on your console? Test using Chrome as IE's debug is just a waste of time. See if you run into any issues there. Is the data coming back from your data location coming back as valid XML?

jmp100 commented 7 years ago

Ok, it's posting in IE console. 0 errors, 1 warning.

More messages are being logged than the console can display. Only the first 1000 messages per second are shown.

jmp100 commented 7 years ago

Attached is nearly 700 test records if you want to test locally. I'm out of ideas on this.

locations.xml.txt

GiancarloGomez commented 7 years ago

I can offer paid support at this point if you’d like. You can email me at support@fusedevelopments.com and I can review options with you.

Thank you, Giancarlo Gomez http://giancarlogomez.com

jmp100 commented 7 years ago

I would have to get approval from client. This is a bug issue with this script. Not sure how that will fly with them.

GiancarloGomez commented 7 years ago

I understand. If they approve you can email me and I can share with you my price sheet. Have a great day.

jmp100 commented 7 years ago

Can you test with the above attached data and give some estimate for a fix? No issues in any browser except IE.. go figure.

GiancarloGomez commented 7 years ago

What version of IE requires support

GiancarloGomez commented 7 years ago

From this point on please contact me via email to further discuss.

jmp100 commented 7 years ago

IE 11

jmp100 commented 7 years ago

@bjorn2404

Is this IE11 script bug issue on deck to be addressed? Test data linked above.

Thanks, James

bjorn2404 commented 7 years ago

@jmp100 My availability right now for providing free support for a free plugin is very limited at this time. This is the first I've heard of any potential issue specific to Internet Explorer but I can try to do some testing this weekend.

jmp100 commented 7 years ago

Thanks bjorn2404, after 544 records IE 11 posts a location in the first position on the west coast when using a central Ohio zip. There are also Canadian locations in the feed. Some of the nearest locations do not post and not sorting by closest location asc. Also, default zoom settings do not work. No issues in Chrome, Firefox and Safari. No console errors reported in IE when debugging. The client reported the issue so the behavior is not unique to my machine. Inline directions are ok, all lead to Minneapolis which is in every test location record.

        $(function() {
            $('#bh-sl-map-container').storeLocator({                
                'dataType': 'xml',
                'dataLocation': 'data/locations.xml',
                'inlineDirections': true,
                'mapSettings': { zoom : 9, mapTypeId: google.maps.MapTypeId.ROADMAP },      
                'storeLimit': '26',
                'debug': 'true'
            });
        });

Thanks, James

locations.xml.txt

bjorn2404 commented 7 years ago

@jmp100 You are missing coordinates for location name 186, which seems to make IE 11 go haywire.

jmp100 commented 7 years ago

Wow..., thanks bjorn2404, that completely got by me. Apparently for that record the postal code is not in the database. I'll set conditions to fix. Thanks again, this issue was on me.