search

bjornbjorn / snippetssync.ee2_addon

Save snippets as files during development
http://wedoaddons.com
21 stars 8 forks source link

Paths updated for DevDemon Updater compatibility #9

Closed proimage closed 11 years ago

proimage commented 11 years ago

Shuffled around the folders so it's compatible with DevDemon's Updater add-on. I also updated the ancillary files accordingly (INSTALLING.txt, changelog.txt, and the version numbers in the .php files).

bjornbjorn commented 11 years ago

Thanks for the pull, but I don't think this is the best way to do it. Unless you have very convincing arguments, I'm going to move the libraries folder into the main "snippetssync" folder - the reason for having it outside in the first place was an idea I had about multiple addons sharing the same libraries (extending bases in this case) - but since it never was officially supported by EE it turned out to be a hacky solution which confused users.

If it's Updater support you're after, I guess this fix will also make sure that it works with Updater?

proimage commented 11 years ago

As far as I'm aware, the only change needed for Updater compatibility is to relocate things under the /system/expressionengine/third_party/ directory. Moving the /libraries/ dir under the /snippetssync/ dir shouldn't affect that one way or another - although it is a good idea to do. :)

bjornbjorn commented 11 years ago

Ah, sorry I misunderstood what you did in your pull. Yepp, modifying the folder structure in the download for Updater support is a good idea - merging it in now :-) .. I will deal with this other issue later.