search

bjornblissing / osgoculusviewer

An OsgViewer with support for the Oculus Rift
Other
106 stars 67 forks source link

Sdk rendering linux #41

Closed danjo133 closed 9 years ago

danjo133 commented 9 years ago

Hi,

This pull request contains some refactoring, both for readability and for making the linux diff smaller.

There is one outstanding issue, that's with:

include "../src/OVR_CAPI_GL.h"

include "../src/Kernel/OVR_Math.h"

I don't know what the best thing to do is, if it's to add that directory to include path or something else.. I have added the OVR_CAPI_GL.h to my OVR.h

What do you think?

bjornblissing commented 9 years ago

I think it would be best if this PR could be split into two separate PR. One for the support for the Linux build and one for the refactoring. Since the history will be much easier to maintain.

Also, most of the refactoring could probably be merged with the master branch as well.

danjo133 commented 9 years ago

Ok, I'll create two new PR:s, for the refactorings, one for master and one for the sdk branch.