search

bjornbm / dimensional

Dimensional library variant built on Data Kinds, Closed Type Families, TypeNats (GHC 7.8+).
BSD 3-Clause "New" or "Revised" License
102 stars 16 forks source link

Support for GHC 7.10.3 up to GHC 8.4.1 with adding Semigroup instance #183

Closed varosi closed 6 years ago

varosi commented 6 years ago

Built and tested

bjornbm commented 6 years ago

Thanks @varosi. Looks good to me. Will give @dmcclean a chance to look before I merge. If he doesn't object of merge by tomorrow I will merge this.

As a side note we should also add more travis test cases, including your ghc84 one.

varosi commented 6 years ago

I have added changes for Travis to test with.

varosi commented 6 years ago

libtinfo.so.6: cannot open shared object file: No such file or directory

I think that somehow we have to install this library on Travis, but I don't have much experiance with it. @bjornbm, could you help on that? All other compilers seems to work fine there. I already tested all of them locally on my Windows 10.

bjornbm commented 6 years ago

Thanks again. I took a quick look and this looks relevant. I'm not familiar with Travis CI though (@dmcclean set it up for us) and don't have time to investigate more right now. I propose to comment out the GHC 8.4 line in .travis.yml for now and open a new issue to investigate.

varosi commented 6 years ago

Thanks!

dmcclean commented 6 years ago

Awesome, thanks @varosi and @bjornbm!