search

bjornbm / dimensional

Dimensional library variant built on Data Kinds, Closed Type Families, TypeNats (GHC 7.8+).
BSD 3-Clause "New" or "Revised" License
102 stars 15 forks source link

To/FromJSON instance #192

Open picca opened 5 years ago

picca commented 5 years ago

It would be great if we could serialize unserialize via Aeson dimensionnal values.

for now we have this.

• No instance for (FromJSON
                     (dimensional-1.0.1.3:Numeric.Units.Dimensional.Internal.Dimensional
                        'Numeric.Units.Dimensional.Variants.DQuantity
                        Numeric.Units.Dimensional.Dimensions.TypeLevel.DLength
                        Double))
    arising from a use of ‘aeson-1.2.4.0:Data.Aeson.Types.FromJSON.$dmparseJSON’

thanks for considering

bjornbm commented 5 years ago

I have no objections but would appreciate a patch if you want it sooner rather than later (I guess it already is “later” – sorry). I'm thinking it will have to rely on Numeric.Units.Dimensional.Dynamic and should probably go in dimensional-dk-experimental or a package of its own.