search

bjornbm / dimensional

Dimensional library variant built on Data Kinds, Closed Type Families, TypeNats (GHC 7.8+).
BSD 3-Clause "New" or "Revised" License
102 stars 16 forks source link

Compiling with GHC 8.6.1 and testing with new-test #194

Closed davean closed 5 years ago

davean commented 5 years ago

The attached patches fix dimensional to work on GHC 8.6.1 and test with new-test. The only problem requiring fixing was that the handling of * at the type level changed. To avoid CPP I used the default-extensions option with a guard in the cabal file. This left an issue with doctests which I handled by manually passing the language extension to the doctest function.

0001-Fix-tests-on-cabal-new.patch.txt 0002-Fix-for-GHC-8.6.1-s-StarIsType-change.patch.txt

peti commented 5 years ago

Ping?

bjornbm commented 5 years ago

Thanks @davean for the patches. See #195. I don't have time to work on this until next week. Feel free to submit an updated patch to speed this up.

bjornbm commented 5 years ago

@davean was it necessary to change * to Type (from Data.Kind) in Dynamic.hs and Internal.hs? Importing Data.Kind breaks GHC < 8. Can you provide pointers to the GHC docs explaining if/why it was necessary?

davean commented 5 years ago

https://github.com/ghc-proposals/ghc-proposals/blob/05721788de9ab6538def68c3c2c9dec50c9f24a8/proposals/0020-no-type-in-type.rst

As of 8.6 XStarIsType is on by default and I believe the compatibility window schedules to be the only option in GHC 8.8.

On Tue, Oct 23, 2018 at 12:19 AM Björn Buckwalter notifications@github.com wrote:

@davean https://github.com/davean was it necessary to change * to Type (from Data.Kind) in Dynamic.hs and Internal.hs? Importing Data.Kind breaks GHC < 8. Can you provide pointers to the GHC docs explaining if/why it was necessary?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bjornbm/dimensional/issues/194#issuecomment-432085623, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOVy7hIQ-WkytUPTf1KYZCkWMpg60t0ks5unpjjgaJpZM4Xbogm .

bjornbm commented 5 years ago

FYI I have merged this into master but cannot yet deploy to hackage due to https://github.com/haskell/hackage-server/issues/788.

FranklinChen commented 5 years ago

Is there still a problem with updating on Hackage?

dmcclean commented 5 years ago

Yes. (I just retried it.)

bjornbm commented 5 years ago

https://github.com/haskell/hackage-server/issues/788 has reportedly been fixed! @dmcclean will you be ready to upload after merging log1p et al?

dmcclean commented 5 years ago

Standby about 2 hours, busy with Christmas cleanup. Excellent news!

On Fri, Dec 28, 2018, 11:58 AM Björn Buckwalter <notifications@github.com wrote:

haskell/hackage-server#788 https://github.com/haskell/hackage-server/issues/788 has reportedly been fixed! @dmcclean https://github.com/dmcclean will you be ready to upload after merging log1p et al?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bjornbm/dimensional/issues/194#issuecomment-450391659, or mute the thread https://github.com/notifications/unsubscribe-auth/AAk00y5nor-YtSh_tQn6pIXhFd28v20Lks5u9k3SgaJpZM4Xbogm .

dmcclean commented 5 years ago

v1.2 uploaded to hackage! (Putting finishing touches on v1.3 which includes the breaking change to non-breaking spaces and a few minor things.)