search

bjornbm / dimensional

Dimensional library variant built on Data Kinds, Closed Type Families, TypeNats (GHC 7.8+).
BSD 3-Clause "New" or "Revised" License
102 stars 16 forks source link

Application of patches from #194 #195

Closed bjornbm closed 5 years ago

bjornbm commented 5 years ago

Will merge with successful Travis build.

bjornbm commented 5 years ago

LTS-2 fails with:

Could not find module ‘Data.Kind’

LTS-10 fails with:

doctest: unrecognized option `-XNoStarIsType'
bjornbm commented 5 years ago

Now builds on GHC ≥ 8 (when Data.Kind module was introduced). Are we ready to drop support for GHC 7.* or do we have to work around the Data.Kind imports?

peti commented 5 years ago

Yes, please merge these fixes! GHC 7.10.3 was released ~3 years ago and I am perfectly happy to see support for it drop if that means we'll get support for recent versions of the compiler.

bjornbm commented 5 years ago

Yes, the Idea was not whether to support current GHC but whether to convolute the code with ifdefs or other mechanisms to maintain support for GHC 7. As for myself I am OK to drop GHC 7. Will merge this coming week unless @dmcclean objects.

On 2 Nov 2018, at 20:52, Peter Simons notifications@github.com wrote:

Yes, please merge these fixes! GHC 7.10.3 was released ~3 years ago and I am perfectly happy to see support for it drop if that means we'll get support for recent versions of the compiler.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

bjornbm commented 5 years ago

FYI I cannot yet deploy to hackage due to haskell/hackage-server#788.