Fixed #191. Non-breaking spaces in show output.

bjornbm / dimensional

Dimensional library variant built on Data Kinds, Closed Type Families, TypeNats (GHC 7.8+).

BSD 3-Clause "New" or "Revised" License

102 stars 15 forks source link

Fixed #191. Non-breaking spaces in show output. #198

Closed dmcclean closed 5 years ago

dmcclean commented 5 years ago

Proposed resolution for #191. Concerned parties please test and see if this breaks any of your usages in undesirable ways.

bjornbm commented 5 years ago

The diffs look good to me and will not break anything for me. I'll test build it later today but if Travis is happy I expect I will be too. Did you test on windows and it renders well in the console(/powershell/whatever)?

bjornbm commented 5 years ago

Just found a few minutes to test. Works great for me. Feel free to merge at your leisure!

I also noted that the exact-pi dependency needs bumping. Feel free to address this too if you want.

dmcclean commented 5 years ago

Yes, I almost exclusively use windows. Usually the standard console. Just tested with powershell (Good suggestion), no problems there. In my git bash / mingw64 shell I get some strange fuzzy boxes, but I am willing to live with that. (Image below)