search

bjornbm / dimensional

Dimensional library variant built on Data Kinds, Closed Type Families, TypeNats (GHC 7.8+).
BSD 3-Clause "New" or "Revised" License
102 stars 16 forks source link

Add `decade` and `century` units #221

Closed konsumlamm closed 2 years ago

konsumlamm commented 2 years ago

Closes #219.

I chose the name data based on that of century, I haven't found any official naming.

bjornbm commented 2 years ago

Thanks and sorry for the tardiness in merging. The pre-existing documentation for Julian year was not accurate (there is no mean Julian year (in contrast to solar or tropical years) since the Julian year is exactly defines). The doctests in form of seconds are probably of little value in terms of useful documentation, so I added some more.

I also pushed version 1.5 with your contributions to hackage.

Many thanks again @konsumlamm !

konsumlamm commented 2 years ago

@bjornbm nice! I found a small mistake in the changelog, it says that century was added, but that already existed.

bjornbm commented 2 years ago

You are correct, I updated the changelog.