search

bjornbytes / lovr.org

LÖVR Website
https://lovr.org
8 stars 3 forks source link

Function listing should support anchors/back history #7

Open mcclure opened 1 year ago

mcclure commented 1 year ago

Since 0.16 or so the lovr-docs repo has listed functions with more than one legal overload with this javascript picker at the top:

https://lovr.org/docs/v0.16.0/lovr.graphics.newBuffer

I love this, before I kept tripping myself up not noticing overloads lower in the file and the new design is clean and convenient.

There is one problem. Because all the overloads are in one page, it doesn't seem to be possible to link to a single one anymore. this is sometimes inconvenient.

IMO, clicking one of the overloads should use JavaScript to set the #anchor (so that links to the current overload can be copied) and set javascript document.history. I have worked with this JS API before and would be happy to implement this change myself if you could point me to how/where the overload directory is set (in a script in this repo? in an external tool?)

bjornbytes commented 1 year ago

Yes, I really want to add this but wasn't immediately able to figure it out while implementing it.

It uses a CSS-only tab system implemented via radio buttons. The JS is in js/docs.js in that repo.

mcclure commented 1 year ago

I'll take a look at it. Thanks.