search

bjornbytes / lovr

Lua Virtual Reality Framework
https://lovr.org
MIT License
2k stars 138 forks source link

Not packaged correctly for MacOS? #165

Closed undefdev closed 5 years ago

undefdev commented 5 years ago

Hey,

just wanted to try the latest version, but I get the following error:

image

In the report we get the following details:

Termination Reason:    DYLD, [0x1] Library missing

Application Specific Information:
dyld: launch, loading dependent libraries

Dyld Error Message:
  Library not loaded: /Users/*/Documents/*/libglfw.3.dylib
  Referenced from: /Applications/LÖVR.app/Contents/MacOS/lovr
  Reason: image not found

I'm running MacOS High Sierra.

bjornbytes commented 5 years ago

Ok, I reuploaded new versions to the GitHub release page as well as the website (had to clear my cache to get my browser to download the new version). Sorry about this!

Background: glfw was packaging itself incorrectly because it was configured for older versions of CMake. I updated glfw to the latest version which fixes it, so this shouldn't happen for future builds.

Thanks again for bringing this to my attention!

jonathanperret commented 4 years ago

@bjornbytes FYI, the GitHub-published release still exhibits this issue (this is my first time downloading LÖVR so I'm pretty confident I did not test an older download).

$ curl -LO https://github.com/bjornbytes/lovr/releases/download/v0.13.0/lovr-v0.13.0-macOS.dmg
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 2212k  100 2212k    0     0  1755k      0  0:00:01  0:00:01 --:--:-- 2119k

$ hdiutil attach ./lovr-v0.13.0-macOS.dmg
/dev/disk4              GUID_partition_scheme
/dev/disk4s1            Apple_APFS
/dev/disk5              EF57347C-0000-11AA-AA11-0030654
/dev/disk5s1            41504653-0000-11AA-AA11-0030654 /Volumes/LÖVR

$ otool -L /Volumes/LÖVR/LÖVR.app/Contents/MacOS/lovr
/Volumes/LÖVR/LÖVR.app/Contents/MacOS/lovr:
    /Users/bjorn/Documents/dev/lovr/build/glfw/src/libglfw.3.dylib (compatibility version 3.0.0, current version 3.2.0)
…

The version I downloaded from https://lovr.org/downloads does have the fixed library path.

Hope this helps.

bjornbytes commented 4 years ago

Okay, it should be working now. I think there was a problem with the GitHub UI I didn't notice when I first uploaded the new dmg. Thanks!