search

bjornelvar / alfred_nba_scores

9 stars 1 forks source link

Update nba.py #2

Closed felippefsm closed 1 year ago

felippefsm commented 1 year ago

The results URL was leading to incomplete url.

Added the missing part ('#box-score') at the end of 'arg'. Now works correctly when we click on a game

bjornelvar commented 1 year ago

Hi! I'm unable to recreate this issue on my end, the current url argument directs me to the box score section on nba.com.

But I see that you closed the pull request but I still have some worries lol.

felippefsm commented 1 year ago

Truth is I'm a GitHub noob lol. But I use this workflow a lot and never been able to access the box score as it leads always to an empty page. So yesterday I looked into it and notice that the link was incomplete as I sad before.

The URL (Lakers v Warriors last night) to me looks like this: '[...]/game/lal-vs-gsw-0042200235/box-score#box-score'

I locally modified the code (nba.py), adding the '#box-score' and now works fine.

But I'm not sure how to modify (or even if I can modify) the code here on GitHub lol. Maybe I'm the only one facing the issue, idk.