bjornharrtell / PgKeyValueDB

MIT License
1 stars 0 forks source link

Naming of the GetSet and GetSetAsync methods #2

Closed Revsgaard closed 6 months ago

Revsgaard commented 6 months ago

The name GetSet sounds like data is both saved and loaded in the method. Maybe rename the methods to GetList and GetListAsync.

Revsgaard commented 6 months ago

@bjornharrtell considered renaming.

bjornharrtell commented 6 months ago

Hehe yes I was confused about them myself yesterday. But I don't like list either since they do return a set.

Revsgaard commented 6 months ago

What about GetHashSet or GetMany...

bjornharrtell commented 6 months ago

Both names are pretty good, now I have do decide which one of them.

bjornharrtell commented 6 months ago

GetHashSet it is https://github.com/bjornharrtell/PgKeyValueDB/commit/175794501faec6a762998d161028ef683dc237f9